libera #monero-dev

16 Jul 2023

Official repo: github.com/monero-project/monero || Don’t ask to ask, just ask:) || Monero GUI dev is at #monero-gui || Monero website dev is at #monero-site || Non-dev questions -> #monero, please || No fork help, you’re on your own

• 05:34
  jeffro256[m]
  <hyc> "jeffro256: of course not." <- Then what's this for? github.com/monero-project/monero/bl…b_drivers/liblmdb/mdb.c#L5819-L5836
• 05:35
  jeffro256[m]
  Can I not just use `MDB_GET_BOTH_RANGE` to put the cursor at the entry where the key <= the key value I pass in passed on the "lexographical" (`memcmp`) ordering?
• 05:36
  jeffro256[m]
  * where the entry key <=
• 05:36
  jeffro256[m]
  * Can I not just use `MDB_GET_BOTH_RANGE` to put the cursor at the entry where the entry key \<= the key value I pass in, based on the "lexographical" (`memcmp`) ordering?
• 05:42
  jeffro256[m]
  * Can I not just use `MDB_SET_RANGE` to put the cursor at the entry where the entry key \<= the key value I pass in, based on the "lexographical" (`memcmp`) ordering?
• 07:10
  jeffro256[m]
  Okay I learned that BlockchainLMDB::compare_hash32 is used to sort the hashes starting from the 7th byte, then the 6th byte, ..., 0th byte
• 07:11
  jeffro256[m]
  Sorry nth uint32_t
• 07:14
  M0xffc[m]
  Facebook/Infer static analysis worked on Monero. Big bunch of nothing burgers! Static analysis is useless for most cases.
• 15:25
  selsta
  jeffro256[m]: is 8949 something you can take a look at and also update the test case to catch this?
• 17:44
  woodser[m]
  my test to scan txs is failing with error message "Expected block not returned by daemon" with this recent commit to wallet2: monero-project/monero 65e13db @jberman
• 17:44
  woodser[m]
  the test merely calls scan_tx with a few of the wallet's tx hashes
• 18:02
  woodser[m]
  might be because I've pulled some commits to the release branch so dependent commits could be missing
• 18:04
  selsta
  woodser[m]: do you have your own tests?
• 18:05
  selsta
  if yes you might want to share the test so that jberman[m] can reproduce
• 18:05
  selsta
  tests run on CI are all green
• 18:31
  jeffro256[m]
  <selsta> "jeffro256: is 8949 something you..." <- I opened a PR here: monero-project/monero #8950
• 18:31
  jeffro256[m]
  But if woodser could provide test cases which trigger the previous assertion, that would be greatly appreciated
• 18:32
  jeffro256[m]
  The new PR I wrote just adds everything to the checking set so if you made the lists inconsistent, it would still be able to block frozen outputs
• 18:32
  jeffro256[m]
  without asserting orderedness