reading 9185, see in conversation: "and use a proper commit title like Doxygen: fix broken links." In contributing.md, the instructions for title are: "That means a subject line that describes the patch". Upon loooking at all the PRs, i do see a lot of this <xxxx>:<aaaa bbbb cccc> . So is xxx like the area of code? trying to refine contributing.md to instruct properly

<t​obtoht:monero.social> gingeropolous: yes, it usually points to a subdirectory under src/ or contrib/ where the changes were made, or more generally describes the type of change

ok., the existing title is "fix broken links". which imo describes the change, but not where i guess

well, im off to do my little bike shed PR

Without the prefix, it only vaguely describes. It could be broken links to the update downloads, to the IRC web proxy, etc. The prefix is a succint way to incresae the accuracy of the rest of the description.

If I see "doxygen: FOO", I know I don't have to care about this patch if I'm not looking at documentation stuff.

indeed. thanks!

hrm, moneromoooo your listed under "monero maintainer team" along with fluffypony and hyc . this is in contributing.md

I guess it means main contributor. I do not (and never had) repo write access. Feel free to remove me.

I recall I have access to close tickets

Ah, I have that too if that's what maintainers means. I was thinking more push rights.

<s​omeoneelse495495:matrix.org> moneromoo, what was the reasoning behind monero-wallet-rpc resolving to `localhost:8080` if no daemon address is provided ? (wallet/wallet2.h, L1000)

This "localhost:8080" has been there (in the "init" function) since the very first commit on github. So it's a remnant of the original Cryptonote codebase

so it's older than when port 18081 was chosen to be used by default

<s​omeoneelse495495:matrix.org> alr, thx for explanations. should i make a pr to change these to 18081 ?

I think you can just remove the default value there

It's always called with daemon address filled in

<s​omeoneelse495495:matrix.org> I'll still make an assertion since docs are stating it is optional

I don't know what would be the good default value there. Port 18081 is default only for the mainnet, but there are also testnet and stagenet

better just remove it

<s​omeoneelse495495:matrix.org> alright

<s​omeoneelse495495:matrix.org> tested, made pr. but omg wallet2.cpp is so laggish, vscode didn't stopped crashing

<t​obtoht:monero.social> SyntheticBird45: please use spaces instead of tabs

<s​omeoneelse495495:matrix.org> fixed 👍️

As for default param, there is a get_config(network_type) which can give you access to the default ports.

<s​omeoneelse495495:matrix.org> done. in case of empty strings set_daemon resolve to `"localhost:" + get_config(m_nettype).RPC_DEFAULT_PORT`

<s​omeoneelse495495:matrix.org> Tested, it resolve to localhost:RPC_DEFAULT_PORT

<s​omeoneelse495495:matrix.org> Tested, it resolve to localhost:RPC\_DEFAULT\_PORT