just did a git pull on p2pool and went to start and got ZMQReader exception Address already in use, aborting

do I need to remove the --zmq-pub command from my monerod?

Either another process is already binding on that port, or the system has it reserved for a minute after the process died. Fix this and restart.

so it looks like whatever change happened over the weekend doesn't play nice with source monerod, removed it and moved back to the one pulled from p2pool and connects fine

yes, it's a bug in the latest code

sech1: is github.com/SChernykh/monero/tree/p2pool-api-v0.17 still the best branch to be building to stay up to date? Or should I switch my guide to using github.com/SChernykh/monero/tree/p2pool-api-release?

I would imagine -release but have been out of the loop for a few days.

I think you can just use the official release-v0.17 branch

my PR was merged

sech1: Ah, from the main repo?

yes

yes

Ok, awesome, will switch and re-build

^ using that on my nodes, works well

having all users with a pre-set config file pointing at the same monerod somewhat defeats the ability to have independently created blocks

but i doubt most of miners care about it

those who care can and will run their own monerod without problem

let them make the choice, default the good option :)

Is 51% attack something to really be worried about or?

Like wouldnt it be possible for the nodes to detect if one single node with 51% hashrate submits suspicious transactions and just ban that node?

There are many small coins that have pools with like 70% hashrate and people buy them for some reason

in the long run, yes, it is really the only attackable surface in a Pow scheme. if it gets valuable enough, any PoW chain will become a target

if the majority of miners are solo or p2pool, that threat goes away

and in general mightysnowman[m] , a 51% isn't great, but its not a death sentence for a cryptocurrency network. For a healthy network, they are difficult to pull off, but in the cases that they do happen, a 51% attack is usually used to double spend, so its exchanges that are usually affected

not really individual users, except for any market effects. but the market seems not to care much about fundamentals

so, .shrugface

i.e., a 51% attack is used to target a specific target, not the entire network

however, in the case of monero and other ringsig based currencies, there can be some hits to privacy

my monerod is being semi-spammed with "Transaction not found in pool", maybe p2pool is trying to ask for transactions that have already been added to blocks? I have a few of my friends p2pools hooked up to my node so it might be an issue with one of theirs

seems to be functional so

seeing this as well, might be cause by p2pool as my private node has a few but public p2pool node has many

that would make sense, thanks for the input

When a block gets broadcast through p2pool it tries to get transmitted again through your monerod node

the template only includes txid list, not the transactions themselves

if you try to broadcast a block with a txid your node does not have, you get that error

some nodes do not have transactions other nodes do have, maybe too new :)

At the moment p2pool has 10s delay before including new transactions it knows about into block templates