monero-project/monero-site #2156 plowsof ? What's the purpose of this pr? Looks like you just cherrypicked my commit and added stuff on top of it. You didn't even reference the already open pr anywhere. Seems like it's just going to be source of confusion.

ErC: forgot to add a ref as only posted it earlier (it replaces 2131) and is ready for review. ive deconstructed your pull request after the suggestions monero-project/monero-site #2131 requested a diff history

so you take my pr and open a new one based on it without a word? Cool.

Your pr? Your commits are creditted from what i can see

i and others made a word in 2131, so rather take action

That's going to be a waste of time. Still, i wished you had a minimum of courtesy and talk to me or make a comment

he did comment

As did hinto

And i asked here for the diffs as well

anyway. i'm not the maintainer, so you are wasting somebody else's time.

Talk abiut confusion and expecting reviewers to do local comparisons.

I already explained why adding those commits on github doesn't make sense and doesn't help with the review process

The reviewers disagree

people can look at the diff locally in 5 seconds.

Hence thr reviee comments

monero-project/monero-site #2156/commits is very clean

The only time plowsof wasted was his own.

Asking people to download and do local diffs is asking people to waste their time. and you made far more changes than necessary, turning a paper wallet into an online generator without updating the documentation.

the issue: moneroaddress.org

the rest of this is a waste of time

Ive had a pr ready to delete the offending sections for well over a month. Hosting o getmonero =/= changing the use case of the page and writing instructions that dont work

Spelling errors and all

If your pr gets reviewed, it will need to be re-reviewed because you have to squash the commits first. So adding all commits like that it's literally a waste of time to anyone that will want to review your pr. And no, leaving the commits inside the repo so you guys can see the diff on github doesn't make sense

Anyway. Feel free to spend your time as you prefer. Still a minimal of courtesy was expected at least from plowsof. Not cool.

ive seen worse but hey, im not pointing fingers

i still welcome anyone to review my pr and suggest improvements. Also to the spelling errors 🙂

i wouldn't squash the commits in this case so that authorship information gets retained and it's clear what is from the original and what changes are applied

bridge dead again, reposting my comment

i wouldn't squash the commits in this case so that authorship information gets retained and it's clear what is from the original and what changes are applied

having separate commits doesn't hurt anyone in this case and is the preferred way to do it

i disagree, but if that's what people prefer, i would have preferred people talking to me directly instead of taking my pr and reopen it.

Just a reminder that only two reviewers expressed the preference, one i don't know and the other one is an extremely toxic individual that i ignore.

so, plowsof who opened the pr didn't mention once his preference too.

if more people would have preferred leaving the commit i would have added it without problems, even if i disagree with it as i did multiple times in past.

taking somebody elses's pr and reopening it changed behind his back it's not nice. This workgroup has been working fine and cooperative for years, let's not start now to behave shadily and in corners

i pinged luigi about the pr. If he agrees with leaving the commit i have no problem with adding it.

Erc please stop

it wasnt your pr to begin with anyway, so get off that horse and just be a professional. Not here to tear apart your lies or bad memory

wasn't my pr?

uh huh

You claimed it wasnt important. Wasnt even your idea

isn't it clear that i'm adapting moo's work on getmonero? There is a clear list of the changes i introduced

issue: moneroaddress.org

anyway i have no interest in talking to you. I just wished i would have been contacted by plowsof first. As i said adding the commit isn't an issue if many people prefer it or the maintainer does

what are we fighting about

kid stuff

:(

can we just ask moneromooo what he prefers

mooooo

Luigi its not jist the diffs

lol you are the maintainer. It's about what you prefer 😛

No it isnt

i don't think moo cares if we add an extra commit to getmonero

🙂

This isnt a dictatorship lol

All this time wasted when people could have written a couple of comments on github and avoid the issue altogether.

as the dictator I take too many opinions into account

I don't think cluttered history (by one commit?) is a big deal at all

Alright (it's a huge commit). Problem solved then. How easy could have been. i'll add the commit tomorrow

good work team

Thanks guys

worst dictator ever

And gals

lol. Creates the mess and then thanks people whose time he wasted 🙂

Lol dont be mad that youre doing what i tokd ya to

it's called collaborative development. In the last 3-0 or so years working on getmonero i added many things i disagreed with. I always tried to maintain a high level workgroup with open discussions and free exchange of feedback.

so, let's try to keep it that way

If these standsrs would have been kept. This wasted time would have been a couple of comments on a pr instead.

Theres comments on the pr

Maybe you cant see them or something?

there are two comments. One if from you, which i ignore and the other one is from somebody i don't know. No, that's not enough for making me change a pr to something i disagree with. A higher amount or the maintainer will do it, as you have seen. Being collaborative instead of distructive can be easy

Nvm. You ignored becauae you didnt recognize hinto. And plowsof first comment came through in an email but i couldnt find it on github

Ignore me now but listen 5 mins earloer

So when i find your errors, you fix en

but i ask you to post the diff so i (and anyone else casually stolling by) can check that as well

as long as you behave toxic as fuck everything you say i ignore. So, keep that in mind

so why did you fix my reported issues

toxic? To bad actors

because they were legit and you reported them in a nice and respectful way.

all the toxic stuff i just ignore

Asking for diffs is toxic?

Now youre doing it bcauae daddy told you to

as you know, im better at being as asshole than you. Keep it professional and i do the same.

getmonero.org/community/hangouts some matrix rooms addresses are oudated, namely #monero-website:matrix.org and #monero-research-lab:monero.social also worth considering delisting #monero-hardware since the channel has essentially been dead for years now

i think it'd also be cool to share the monero matrix space link in that page, maybe above - on Workgroup Resorces

getmonero.org/community/workgroups here too

charuto thanks, i think only monero-site is wrong? monero research lab is on monero.social

are we haveno.network or monero.social here 😵

plowsof11: the links for mrl are linking to monero-research-lab:matrix.org

which is a working alias, but probably not ideal.

apparently, neither

ah sorry, thanks, will fix

and +1 for showing the monero space there

so the MATRIX button to link to matrix.to/#/#monerospace:monero.social? great idea